feat(nocloud): add optional network file name#164
Open
CorentinPtrl wants to merge 1 commit intocloudbase:masterfrom
Open
feat(nocloud): add optional network file name#164CorentinPtrl wants to merge 1 commit intocloudbase:masterfrom
CorentinPtrl wants to merge 1 commit intocloudbase:masterfrom
Conversation
|
Would be nice if we could merge this. As it would fix a couple issues when trying to add auto deploy Windows Nodes to Proxmox plus some kubernetes flavors dont merge network configs into meta data. So you end up needing to manually configure networking. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the network config for proxmox since the naming is different for the network config (NETWORK_CONFIG)
related to #89